Divya Goal

Divyagoalescor03 Dec, 2021Games

I don't know this code well (in fact I'm not sure why you picked me as a reviewer), but off the top of my head: the question is not just whether tokens_iterator happens to be the same thing as const Token * now. It's whether it's guaranteed to stay that way in the future. One of the purposes of these iterator types is that they form an opaque abstraction layer: the client uses the type in only the ways that are guaranteed to work by the iterator specification, and then the implementation can completely change without breaking any client.